add ci_args to npm ci run cmd #33
Conversation
allow us to pass explicit args to npm ci cmd, e.g. `npm ci --legacy-peer-deps`
|
Looks good to me. I wonder if we should enable |
I think that's a good idea, i've proposed that in #34 and if folks think that is useful i'll rebase this over that change before merging. |
There was a problem hiding this comment.
Revisiting this and it looks good. At the moment, there's no test associated with the "NPM Build" action. Could you throw a quick one together, either pulled from a test repo or self-contained? It just needs to be the absolute minimum required to allow the shared workflow to run the build command and save the artifact. Happy to help get it going, I'm just not sure what the best way to test the barest-bones npm repo is--check out the other two tests to see what I mean.
With simple test included, we can ensure that changes to the workflow (syntax, versions, stuff like this) work within the context of the action before merging. Thanks!
fixes #32 allow us to pass explicit args to npm ci cmd, e.g.
npm ci --legacy-peer-depsI wasn't sure how to best handle this with say an optional boolean input (default to false) that turns on this specific behaviour to limit the scope of what can be passed to
npm cicmd (non trivial and complicated the action setup. So i chose the allow any flag to flow through via the args string input which will allow us to morph the npm ci behaviours as required. Happy to revisit if folks think this is too opendetails on the args we can pass to
npm ci